Jump to content

Leaderboard

Popular Content

Showing content with the highest reputation on 10/12/2022 in all areas

  1. I don't think it's mandatory to create a branch for a pull request although it's often done... sound_options.cpp ? Well that's what happens with so many PR, I might have missed one. Well I checked your patch-1 branch, it was about gui.cpp, and your main branch doesn't contain any commit from you, so I don't know where this commit is. It's good, I could retrieved your changes from github, you just won't see your name in the from for the commit, but I cited "mer-curious" in the comment, and updated the locale files too. And the reason why I missed is because I merged all this manually because there were too many, I saw they were named as patch-1, patch-2, etc... so I didn't try to check, I just got all these patches, and missed this one because it was named differently. Next time make all your edits in the same branch then make a pull request for this branch alone, it will make things easier, if there is a next time !
    1 point
  2. https://hbmame.1emulation.com/ What's new in HBMAME ==================== 2022-10-12 0.245.7 New Games --------------------------------- - [aburtest] Afterburner Test Rom (v0.1) - [aburtest1] Afterburner Test Rom (v0.11) - [frogtest2] Frogger Test Rom (2019-01-27) - [galxtest2] Galaxian Test Rom (2017-12-07) - [gyrutest] Gyruss Test Rom (2021-06-27) - [gyrutest2] Gyruss Test Rom (2021-09-29) - [hypetest] Hypersports Test Rom (0.5 test) - [moontest] Moon Cresta Test Rom (2017-12-07) - [mrdotest] Mr. Do! Test Rom (2017-12-07) - [pacmtest2] Pacman Test Rom (set 3) - [pbobble3s02] Puzzle Bobble 3 (Recarbonated, 2p only) - [phoetest] Phoenix Test Rom (2017-12-07) - [pooytest] Pooyan Test Rom (set 1) - [scobtest] Super Cobra Test Rom (2019-01-27) - [scratest] Scramble Test Rom (2019-01-27) - [senctest] Space Encounters Test Rom - [sinvtest] Space Invaders Test Rom (SMv1.0) - [sinvtest0] Space Invaders Test Rom (v1.0) - [sinvtest1] Space Invaders Test Rom (v1.1) - [sinvtest2] Space Invaders Test Rom (v1.2) - [sinvtest3] Space Invaders Test Rom (v1.3) - [spectest] Spectar Test Rom - [theglad104] The Gladiator (v104) - [trkftest07b] Track and Field Test Rom (0.7 beta) - [trkftest08b] Track and Field Test Rom (0.8 beta) - [trkftest09b] Track and Field Test Rom (0.9 beta) - [trkftest10b] Track and Field Test Rom (1.0 beta) - [trkftest11b] Track and Field Test Rom (1.1 beta) - [trkftest12b] Track and Field Test Rom (1.2 beta) - [trkftest11t] Track and Field Test Rom (1.1 test) - [trkftest12t] Track and Field Test Rom (1.2 test) - [trkftest12tu] Track and Field Test Rom (1.2 test, unencrypted) - [twinqixs01] Twin Qix (Japan)
    1 point
  3. Well it would have been better to have 1 pull request only for all these changes, which would make only 1 commit to merge, but considering the conditions in which you did that, I guess I have no other choice than to accept that... ! There is a magic command for that when the files are on your disk : grep, it goes like this : cd source/sdl/dialogs grep -i "load game" * -> game_options.cpp: TMenu *load = new TMenu(_("Load game"),menu); -> game_options.cpp: { _("Load game"), &my_load }, This is in the description of a control, so it's in source/sdl/control.c. What do you want it for ? Or just don't change it, I am not going to look into 2 places for the savegames ! Ok, I'll go looking at this ton of pull requests then... ! Merged all this manually to be able to merge all these commits in just one, I made the mistake of merging the 1st one from the interface, so the repository had a commit that I was forced to overwrite shortly after, but anyway. Also updated the locale files so that all the translations continue to work. I should at least update the po files to merge the new strings, but I forgot everything about these commands, I guess I should investigate one day...! Anyway it's merged. (and congratulations for your impressive determination to have this done !)
    1 point
×
×
  • Create New...