Raine 0.96.12 : the revenge of ffman1985 !

[Tux]

Did you notice he didn't send any script update for 0.96.11 ? It's because he was working like crazy on a huge update... !
And that's finally 16 new scripts and 5 updated ones for 0.96.12. The short names of the games handled this time :

wakuwak7, wh1, wh2, wh2j, whp, aof3, aof, aof2, doubledr, fatfutsp fatfury1, fatfury2, kabukikl, kof94, ninjamas, samsh5sp, samsho, samsho2, samsho3, samsho4, samsho5 !

Sorry I am too lazy to get the long names, you can either display the short names in the game list in raine, or pass the short game name on the command line when launching it (which is a feat in windows, I know !), or if you have nothing else, an internet search will give you the long name.

Except that I added some other fixes for the windows placement/status, and added the ability to eject the neogeo/neocd memory card in neocd options, mainly for pbobblen hack, to be able to run it without 1st dealing with the file of its memory card. Ah also fixed a big buffer overflow for 24bpp games added in previous version, but you didn't have time to notice that, did you ?

You can get this there : http://raine.1emulation.com/download/latest.html

(we should be able to take long holidays after that !)

EDIT : just uploaded 0.9612a with an update for the roms for samsho2pe sent by mer-curious 5 minutes after the release of 0.96.12 ! Anyway, here are the changes for this new rom which you can already get from internet archive : https://github.com/zelurker/raine/commit/f96079448381e97c4181b19b01827006e175ffeb
 

[pmc2]

Hello, do you think you could make us a simple changelog, it would take you less time to write and it would be more concise for the rest of us who relay your news, thanks for this version  

[Tux]

Hey I do my best here, the total changelog is on git, but it's quite technical of course, this post here is a condensed version made to be read by non technical users, well I guess I could add a cumulative changelog file in the archive, but it would require to maintain it separately and writing docs is really not what I prefer. Now it's an open project, if someone wants to help...

 

[mer-curious]

Hello Tux! Thank you so much for this new release.

I finally had some time to make some tests and report here in the forum. Unfortunately there are still some remaining issues in the window manager. I'll list them below:

1) If you are in floating window mode and toggle full-screen mode, when you return to the desktop environment Raine window will be uncentered. Take a look:

https://drive.google.com/file/d/1QaQ2z1I3ht6dYasK_ZLuCF6y5JH9xNys/view?usp=sharing

Edit: I forgot to mention that the original window size is also lost.

2) I think this is a new issue I found: if you toggle full-screen mode by using the option in the video options the game picture will be different than using Alt+Enter. It will have bigger black bezels around the picture in right, left and above the screen. Take a look:

https://drive.google.com/file/d/1Ivq0o-5zTLFK4uyIRSUpDrBXx6klPJp4/view?usp=sharing

Pay attention that during the video options menu the game picture is displayed correctly in full-screen, but then when you leave the GUI it will present those bezel issues. Interesting... 🤔

That's it for this fast report. Hopefully you will be able to fix these last issues once and for all. I also miss being able to toggle full-screen mode from a maximized window state. Maybe one day you could re-enable that feature...

Anyway, thank you so much in advance for your work. 👍

PS: I also second ffman1985's opinion on repositioning the IPS option in the main menu. That's one of the reasons why I suggested returning it to the game selection menu, since it is minimally used by the user most of the times. FBNeo also places this feature in the game selection menu. I also think it would let the main menu more organized with hiding less used options and displaying only more important functions.

Edited July 22, 2024 by mer-curious

[Tux]

Ok, I'll move this anywhere else. Since I use raine menu on the keyboard I don't care where the commands are, I just type the 1st characters of the command all the time.

For your windows, sorry you are the only one complaining about that, and I am done playing with this, it will remain like that until I feel like playing with these super stupid things again, or decide to remove entierly this because it clearly looks like it wasn't such a good idea to add this after all. Raine is an emulator, not a window manager !

Moved preload ips dat files just below change/load game.

[mer-curious]

Hello Tux! I feel that those remaining issues in the window manager are similar to the ones I experienced using the maximized window mode. So maybe if/when you fix them we could probably have the maximized window full-screen toggle back.

Thank you so much again for your work.

[mer-curious]

Hello Tux! I've pulled a little request on Github to update Samurai Shodown 2 Perfect Edition to the latest version according to the FBNeo repository. Please check it and see if everything is right.

Aside from that, it's been a little difficult to use Raine lately because of the remaining bugs in window manager in Windows, especially the first one I mentioned in this thread. I change from full-screen to windowed mode frequently so it's not so user friendly to have to move and resize the window in order to use the program after leaving full-screen. The second bug I reported is a new issue and it will only show when using the full-screen option in the GUI.

Anyway, hopefully you will fix these too some day...

Finally, sometimes I have the impression my records keep being overwritten in NeoGeo even though I have selected the per-game save option. I'll see if I can reproduce it safely in order to file a bug report for you to check it.

Thank you so much for your work.

PS: it seems archive.org is down due to a hack attack. If it doesn't work for you to get the updated roms for samsho2pe, you could try to get them from retroroms.info. It requires a quick registration though. Otherwise I can upload the changed files for you.

Edited October 20, 2024 by mer-curious

[Tux]

Sorry for your bugs, I told you it was all a bad idea and I wanted to remove all this crap in the last version, you refused, too bad !

Now most people don't change the video mode often so I don't think there is a lot of people who has any problem with that except you !

And sorry but I don't plan to make any update on this front any time soon, although I committed some small change lately because I found a problem in galaxian when in debug mode, but only in debug mode !

For the git commit, it's just to avoid a warning, a single click or the press of the esc key should be enough, but I accepted the commit anyway, but you'll have to learn how to make your own version if you want a binary here, it's not complicated, you don't need to know how to write C code to compile it.

Thanks for the retroroms.info info (!), I used it to check your patch works, I confirm it does. archive.org should be back to normal very soon now, it was already announced a few days ago, probably for this week then...

Now I have read the hackers who did that were pretty crazy, it was to protest against the usa, archive.org is free, but they say it's American, so it's evil... ! I didn't think there was a big security hole in archive.org, but you don't always get this kind of rights because of a security hole... anyway they said they took their time to reinforce the security of archive.org so it will come back better than ever ! (sorry lost the link about all that, it was from slashdot).

The latest part of this story : https://it.slashdot.org/story/24/10/20/1733227/internet-archive-users-start-receiving-email-from-some-random-guy-criticizing-unpatched-hole

[mer-curious]

On 10/20/2024 at 3:27 PM, Tux said:

Sorry for your bugs, I told you it was all a bad idea and I wanted to remove all this crap in the last version, you refused, too bad !

Now most people don't change the video mode often so I don't think there is a lot of people who has any problem with that except you !

Hello Tux! Thanks for the fast reply!

I think the window manager feature was a nice addition all in all and it is working fine, except for the two issues I reported in this thread. They are quite easy to reproduce in Windows, maybe not in Linux? But if you could try to program in Windows maybe it would be easier to fix them...?

Now if it becomes something impossible to resolve then I also agree that they could be removed, even though this would mean discarding hours of work you put into it.

 

On 10/20/2024 at 3:27 PM, Tux said:

For the git commit, it's just to avoid a warning, a single click or the press of the esc key should be enough, but I accepted the commit anyway, but you'll have to learn how to make your own version if you want a binary here, it's not complicated, you don't need to know how to write C code to compile it.

Thanks for accepting the code in the project!

No problem, I can wait for a next release.

I was wondering if you have ever thought of a build bot for Raine... This is what most emulators do nowadays so users can experience the most recent changes in the code without waiting for an official versioning release.

 

On 10/20/2024 at 3:27 PM, Tux said:

Thanks for the retroroms.info info (!), I used it to check your patch works, I confirm it does. archive.org should be back to normal very soon now, it was already announced a few days ago, probably for this week then...

Yes, I was also surprised to see the site was down. I thought first it had something to do with Nintendo and their hunt for Switch emulators, but then it was apparently a hack attack as you said...

Anyway, thank you again for your time and work.

[Tux]

Yeah all this because they forgot a credential in an open server and it stayed there for years until this stupid group decided to use it... Millions of credentials stolen after that, what a mess... ! Anyway, I guess it should be fixed soon now. For switch emulation those interested kept the binaries already, and suyu is still maintained.

I might take a look at your window problem later at least to check if it's so easy to fix, but I doubt it.
edit : of course it doesn't happen in linux, at least not in window maker which I use. Now seeing why this stupid windoze broke things again will take more time, so maybe later !

[Tux]

The forum seems mostly broken, I can edit the previous message but not post the changes ! so here is the last part :

edit2 : for the 1 there is a quick fix indeed, just don't try to position or scale the window when exiting fullscreen in windows. Now I didn't test this thoroughly, it just works in the case no config file -> fullscreen -> windowed mode.

For the 2nd case, I don't have it, don't know what you did with your parameters, and I don't really want to know neither.

Here is a very last build just to close this for good, and no I didn't experiment with automatic builds because it would be messy to build the 32 bit version probably, might be possible for the 64 bits version only but it takes time to check this.

http://raine.1emulation.com/archive/tux/raine.7z (it replaces a previous raine.7z from 2022).

[mer-curious]

18 hours ago, Tux said:

edit2 : for the 1 there is a quick fix indeed, just don't try to position or scale the window when exiting fullscreen in windows. Now I didn't test this thoroughly, it just works in the case no config file -> fullscreen -> windowed mode.

Hello Tux! Thanks a lot for this fix and thanks for providing a preview build.

I tested it here and it indeed fixed issue number 1!

 

18 hours ago, Tux said:

For the 2nd case, I don't have it, don't know what you did with your parameters, and I don't really want to know neither.

I understand, issue number 2 seems more complicated indeed. I can still reproduce it even with the preview build you provided above.

Here is how I do it: in a new installation of Raine (without raine.cfg file), load a game and enable full-screen in the GUI. You should see thick black bezels around the screen, more noticeable in the top. See a comparison here:

Full-screen mode through Alt+Enter (normal bezels):

 

Full-screen mode through GUI option (thick bezels in top, left and right of the screen; bottom seems normal):

 

Aside from that, I've noticed that if you leave full-screen mode through the GUI option the window will be uncentered again and the full-screen size will be preserved in windowed mode, see below:

You can see all this happening live in this capture I've just made with the preview build:

https://drive.google.com/file/d/1T4hwJhWrpnQ1BfjptXQX8ZEzQhU5cId3/

My guessing is that issue number 2 is related to the fact that the full-screen option in the GUI may work differently from the one with Alt+Enter, so the scaling fix that worked for exiting full-screen with Alt+Enter didn't work for exiting full-screen using the GUI option.

Maybe this could help you figure it out once and for all...?

 

By the way, I think I may have found a new issue in Raine:

I was trying to capture screenshots using the print-screen key in Windows and noticed it is broken. I hit print-screen key to capture something and the result is totally different from what the screen is currently showing, take a look:

Case 1: I hit print-screen key when Cadilacs and Dinossaurs was showing the 3-player demo in the stage, and this is what the capture shows:

I entered full-screen mode using Alt+Enter here, and the capture showed the game logo, not the 3-player demo stage which I was displaying at the time I hit the key. Curiously this capture is also showing thick bezels in top, left and right of the screen, which happens when entering full-screen from the GUI option... Maybe those video issues could be possibly related...?

 

Case 2: I hit print-screen key when Cadilacs and Dinossaurs was showing the 3-player demo in the stage, and this is the result of the capture:

This time I entered full-screen mode using the GUI option, and I was also showing the 3-player mode stage demo. Instead I got this capture which is a mixture of GUI and game screen in a smaller resolution...

 

Anyway, I'm not sure if you were already aware that the print-screen key was broken in Windows, so I decided to report it again since I came across the issue recently. I was trying to capture the difference in the bezels. I ended up playing the videos in a video player in full-screen and then finally using print-screen key to make the captures properly to show you the differences. I'm glad I could think of this solution.

 

18 hours ago, Tux said:

Here is a very last build just to close this for good, and no I didn't experiment with automatic builds because it would be messy to build the 32 bit version probably, might be possible for the 64 bits version only but it takes time to check this.

http://raine.1emulation.com/archive/tux/raine.7z (it replaces a previous raine.7z from 2022).

Thanks again for the preview build. I believe a build bot would be good for these cases in which you try a fix that needs testing. Even if it worked only for 64 bit versions, it could be useful in the future, especially if/when Raine starts receiving more contributions from different people in different moments.

Thank you so much again for the work put into fixing those window issues. Hopefully this will improve the quality of life of the program.

PS: I am willing to test another preview build if you need.

Edited October 23, 2024 by mer-curious

[Tux]

Sigh, as I already said, I don't get your black borders in dino ! For info the code to toggle fullscreen from the gui and from keyboard is exactly the same, it's not twice the same code, it's really the same code called from 2 places, and fullscreen from the keyboard is always desktop fullscreen, so I don't know how you got a fullscreen with black borders and 1 without, I can't do it, even in windows. For info here it's always without borders.

Now it took me a while to understand how you could get this maximized window in the middle of the screen while exiting fullscreen from the gui : it's because you used the REAL fullscreen, 1 I should have removed completely since all the game these days use desktop fullscreen anyway, and when you see the insanity in windows you understand why !). So this part I can fix again, it's again some windows insanity : yesterday I just avoided to send 2 commands to place the window and scale it when exiting normal fullscreen in windows. Well if you don't send these 2 commands when exiting REAL fullscreen then you get this maximized window in the middle of the screen ! It doesn't make any sense, I know, this is microsoft's world... ! So I made a workaround by having a variable to keep the previous value of the fullscreen state to decide if I send these 2 commands or not. I made this fix, but it's probably better to remove this real fullscreen mode completely and just don't use it, so far there is no good reason to keep it.

For your print screen game, I don't play this kind of game, print screen is the window way to take a screenshot, if it doesn't work in windows I can't do much about it. The raine's key to take a screenshot is ctrl-S by default but it doesn't work from the gui. The print screen key is not broken for me actually in windows, it did its job correctly last time I tried it, but I am not going to reboot again just to test with dino during its demo mode (typing this mail in linux yeah).

I updated the raine.7z file, get it from the previous link.

edit : I also have the print screen problem, it doesn't seem to like the gui fullscreen mode, oh well... !
a side note about the gui screenshots not working : in the old allegro version and even the sdl1 version, the gui was rendered to a bitmap, and then the bitmap just displayed on screen, so it was very easy to save a screenshot of it.
With sdl2, it's totally different, the game screen is rendered to a special streaming texture which is updated for each frame, and the gui is just drawn on top of it. So there is no single bitmap to get the picture from, that's why I didn't bother to make the screenshot function to work, since the ingame function works, it's enough.
Anyway in linux (using windowmaker here, I didn't try any other window manager though), you can take the screenshot correctly in the same situation, but there's no insanity here like in windows ! Proof :

[mer-curious]

21 hours ago, Tux said:

Now it took me a while to understand how you could get this maximized window in the middle of the screen while exiting fullscreen from the gui : it's because you used the REAL fullscreen, 1 I should have removed completely since all the game these days use desktop fullscreen anyway, and when you see the insanity in windows you understand why !). So this part I can fix again, it's again some windows insanity : yesterday I just avoided to send 2 commands to place the window and scale it when exiting normal fullscreen in windows. Well if you don't send these 2 commands when exiting REAL fullscreen then you get this maximized window in the middle of the screen ! It doesn't make any sense, I know, this is microsoft's world... ! So I made a workaround by having a variable to keep the previous value of the fullscreen state to decide if I send these 2 commands or not. I made this fix, but it's probably better to remove this real fullscreen mode completely and just don't use it, so far there is no good reason to keep it.

Hello Tux! Thank you again for providing a test build. I tested it here and I no longer have the broken scaled window after leaving full-screen mode from the GUI.

I think I understood what you did. I was activating "full-screen mode (real)" and then leaving this mode, that's how I was producing the broken scaled window issue again. I tried it here with the first test build you provided and it's indeed fixed for "full-screen mode (desktop)" even if enabling and disabling through the GUI.

So it seems all the issues with the window manager are finally gone in Windows?

Now I was wondering if the forbidden function of "maximized window -> full-screen mode" could have also been fixed after these recent changes? If so, the function could be enabled again, no?

 

21 hours ago, Tux said:

Sigh, as I already said, I don't get your black borders in dino ! For info the code to toggle fullscreen from the gui and from keyboard is exactly the same, it's not twice the same code, it's really the same code called from 2 places, and fullscreen from the keyboard is always desktop fullscreen, so I don't know how you got a fullscreen with black borders and 1 without, I can't do it, even in windows. For info here it's always without borders.

Thank you for your testing. I'm surprised that you couldn't reproduce it there. Here it is very consistent and with every game I try, no matter if it is from CPS1, 2 or NeoGeo.

Thick black bezels with CPS1 game Knights of the Round:

Normal black bezel:

 

Think black bezels with NeoGeo game Art of Fighting:

Normal black bezel:

It is more difficult to notice in NG games because the game is originally in 4:3, but you can still notice we have a black bezel produced in the top of the screen.

I use here the ever most default options in Raine, I download the zip for the 64 bit version or Raine 0.96.12a, include the required DLLs and do what you see in the video captures (run the game, enable full-screen through the GUI, and then thick bezels appear in top, left and right of the screen).

Maybe you forgot to enable full-screen mode from the GUI option in your testings...?

Expect that, I don't know what could be causing this... I don't have the most recent Nvidia drivers installed, but this is not likely to be the cause I guess...

Hopefully you'll reproduce it eventually as well as you have with the print-screen bug.

 

21 hours ago, Tux said:

edit : I also have the print screen problem, it doesn't seem to like the gui fullscreen mode, oh well... !

Thank you so much for your testing and thorough explanation. PCXS2 is another emulator in which the print-screen key is broken. I don't know why they haven't fixed it yet since they have a few more contributors than Raine, but maybe it's something with SDL2...?

I think it's nice to have this function working because pressing a dedicated key for that in the keyboard is much more intuitive than learning a screenshot keyboard shortcut for every program you have in the PC. But if it's too difficult to resolve it can be left for another time...

Thank you so much again for your time working on these recent issues and for your attention in the forum.

[Tux]

Maybe it's just a sync problem when you choose the real fullscreen mode, normally these modes have nothing special for sync, but except that...

But anyway knights is a 16:9 game, 384x224 it's 1.71 16:9 being 1.78), but I guess you took care not to use real fullscreen modes here again didn't you ?
Anyway if the scaling parameters are normal it tries to apply the same scaling value to w and h so that at least one dimension takes the whole screen. For knights it's normally the horizontal screen which is full, there is a very thin black border on the top. That's why it's impossible to get a black border around the whole picture here, it's either w or h which is maximized. Unless your super windoze chose a video mode with some sync problem which forces black borders, use desktop fullscreen only, it uses the same sync as the desktop so there should be no black borders, and I really don't understand how you could miss that you were using real fullscreen modes, if you want to do it from windowed mode you have to choose left in the gui... anyway removed soon if I make another binary one day. (or you have something which reports a wrong resolution, I never heard of that).

For the gui screenshot I might be able to add some code to be able to take a screenshot from raine (I guess just make the same keyboard shortcut to work from the gui), but you can't do much for the way windows does things here.

And the reason I disabled maximized -> fullscreen is because it becomes almost impossible to restore the window for maximized state in windows, so it's still the case.

And for the print screen key not working, it might be microsoft's way to try to discourage the use of opengl programs in favor of direct3d, except that it's stupid since if you want to be able to run your program on something else than windows, direct3d is not an option !

edit : another "confidential" binary for you to play with, it recognizes the 1st 2 emulator keyboard controls from any gui dialog, the 1st being screenshot, and the 2nd switch to fullscreen. Which means that poor windows users who can't take a screenshot using the print screen key will now be able to use the standard raine key for that at least ! And you'll be able to switch to/from fullscreen using your chosen key, alt-return by default. By the way real fullscreen is removed. By the way the code to take a screenshot from the gui is shamelessly copied from the old dos allegro version with minimal modifications : png instead of pcx, and calls ogl_save_png in the end to save the picture (same thing as the game drivers). Contrary to the allegro version, you'll get a message box telling you the filename of the screenshot when it's done.

The link is still the same : http://raine.1emulation.com/archive/tux/raine.7z